[PATCH] D23824: [ADCE] Add handling of PHI nodes when removing control flow
David Callahan via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 1 09:10:13 PDT 2016
david2050 marked an inline comment as done.
Comment at: lib/Transforms/Scalar/ADCE.cpp:450
@@ +449,3 @@
+ // force some predecessors live (such as "br label %end" in block
+ // "cond.false") to correctly model the control dependence.
I ran an experiment by prioritize that we keep the lexically last defined value. This should bias toward forcing live earlier branch decisions which are likely to be forced live anyway if we mark a later branch live. This had minimal impact on the my set of C++ tests (two changes, in different directions).
More information about the llvm-commits