[PATCH] D24138: [llvm-readobj] - Teach readobj to print DT_AUXILIARY dynamic tag in human readable form.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 11:07:06 PDT 2016


echristo accepted this revision.
echristo added a comment.

One inline comment.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1554
@@ -1553,2 +1553,3 @@
   LLVM_READOBJ_TYPE_CASE(MIPS_OPTIONS);
+  LLVM_READOBJ_TYPE_CASE(AUXILIARY);
   default: return "unknown";
----------------
emaste wrote:
> This list has a mostly-alphabetical order as well as OS or processor-specific grouping it seems. Should we (separately) add comments to separate the individual blocks?
Alphabetical and possibly with blocks would be nice, yes.


https://reviews.llvm.org/D24138





More information about the llvm-commits mailing list