[PATCH] D24073: [AArch64] Support stackmap/patchpoint in getInstSizeInBytes

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 03:55:41 PDT 2016

rengolin added a comment.

Now that looks good to me.

I don't like much the tests, because if the branch relaxation algorithm change, this test can "fail" without really failing, and whoever hits this will have a hard time understanding how to make this test proper. But I have no better idea.

I'll leave this be for a while, see if anyone else has a better idea. If not, having those tests are better than nothing, and we can work on trying some unit tests in the future.


More information about the llvm-commits mailing list