[PATCH] D24070: Setting fp trapping mode and denormal type

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 11:22:20 PDT 2016

echristo reopened this revision.
This revision is now accepted and ready to land.

Comment at: llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp:455-461
@@ -455,1 +454,9 @@
+  if (TT.isOSBinFormatELF()) {
+    if (!M.empty()) {
+      // FIXME: this is a hack, but it is not more broken than
+      // resetTargetOptions already was. The purpose of reading the target
+      // options here is to read function attributes denormal and trapping-math
+      // that we want to map onto build attributes.
+      TM.resetTargetOptions(*M.begin());
+    }
No, this isn't the right place or way to do this.

You are going to want to look at iterating over the functions in a module in order to collect and collate options if you want to set a global asm marker.



More information about the llvm-commits mailing list