[PATCH] D24104: Make GlobalsAA ignore dead constant expressions.

[Daniel Berlin via llvm-commits]

Theoretically, nothing checks or enforces this (at least in the current PM).
Is it checked/enforced in the New PM?

If an analysis does something like "require LCSSA", it will modify the IR.


On Wed, Aug 31, 2016 at 4:22 PM, Hal Finkel via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> hfinkel added a subscriber: hfinkel.
>
> ================
> Comment at: lib/Analysis/GlobalsModRef.cpp:277
> @@ -276,1 +276,3 @@
> +      // AnalyzeUsesOfPointer assumes all uses of the value are live.
> +      F.removeDeadConstantUsers();
>        if (!AnalyzeUsesOfPointer(&F)) {
> ----------------
> mkuper wrote:
> > Don't know enough about GlobalsAA to approve this anyway, but as a
> matter of principle - is it acceptable for an analysis pass to modify the
> IR?
> No, they shouldn't.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D24104
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160831/5718049c/attachment.html>