[PATCH] D24104: Make GlobalsAA ignore dead constant expressions.

[Daniel Berlin via llvm-commits]

In theory yes, in practice, it probably shouldn't.

In particular, i would never expect *this* pass to modify the IR.

Is there some reason things don't get cleaned up that means this pass has
to clean them up?


On Wed, Aug 31, 2016 at 3:56 PM, Michael Kuperstein via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> mkuper added inline comments.
>
> ================
> Comment at: lib/Analysis/GlobalsModRef.cpp:277
> @@ -276,1 +276,3 @@
> +      // AnalyzeUsesOfPointer assumes all uses of the value are live.
> +      F.removeDeadConstantUsers();
>        if (!AnalyzeUsesOfPointer(&F)) {
> ----------------
> Don't know enough about GlobalsAA to approve this anyway, but as a matter
> of principle - is it acceptable for an analysis pass to modify the IR?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D24104
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160831/93d3f280/attachment.html>