[PATCH] D23829: [ELF] - Use std::regex instead of hand written logic in elf::globMatch()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 12:52:35 PDT 2016

>>I do not think that set a srror in case of invalid pattern is fine. As we might want to call it second time with valid one.

Ah sorry, I forgot that pattern is compiled once in constructor.
That way it probably should never be invalid in match(). At least I think it is not job of a match()
method to mark object with error here. that is already done in constructor.


More information about the llvm-commits mailing list