[PATCH] D23829: [ELF] - Use std::regex instead of hand written logic in elf::globMatch()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 11:08:21 PDT 2016

grimar added a comment.

In https://reviews.llvm.org/D23829#530626, @ruiu wrote:

> How about defining a copy constructor to llvm::Regex and create mutable copies from const Regexs? Regex seems to be just two-pointer-sized object so copying it should be cheap.

And wrap llvm_regex *preg into something like std::shared_ptr with custom deleter ?


More information about the llvm-commits mailing list