[llvm] r280158 - llvm-readobj: speculative fix for MSVC

Yung, Douglas via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 11:50:15 PDT 2016


Hi Saleem

Your fix is still failing to build with on Windows when built with Visual Studio 2013. The error I am seeing is:

C:\src\llvm\tools\llvm-readobj\ELFDumper.cpp(3243): error C2899: typename cannot be used outside a template declaration

Can you look into this?

Douglas Yung

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
> Behalf Of Saleem Abdulrasool via llvm-commits
> Sent: Tuesday, August 30, 2016 14:21
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r280158 - llvm-readobj: speculative fix for MSVC
> 
> Author: compnerd
> Date: Tue Aug 30 16:21:07 2016
> New Revision: 280158
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=280158&view=rev
> Log:
> llvm-readobj: speculative fix for MSVC
> 
> Use the typedef rather than using to type alias the typename.
> 
> Modified:
>     llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
> 
> Modified: llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-
> readobj/ELFDumper.cpp?rev=280158&r1=280157&r2=280158&view=diff
> =======================================================================
> =======
> --- llvm/trunk/tools/llvm-readobj/ELFDumper.cpp (original)
> +++ llvm/trunk/tools/llvm-readobj/ELFDumper.cpp Tue Aug 30 16:21:07
> 2016
> @@ -3240,7 +3240,7 @@ void GNUStyle<ELFT>::printNotes(const EL
> 
>    auto process = [&](const typename ELFFile<ELFT>::Elf_Off Offset,
>                       const typename ELFFile<ELFT>::Elf_Addr Size) {
> -    using Word = typename ELFFile<ELFT>::Elf_Word;
> +    typedef typename ELFFile<ELFT>::Elf_Word Word;
> 
>      if (Size <= 0)
>        return;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list