[PATCH] D24090: [SLP] Sink debug after checking for matching types/opcode.

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 10:34:29 PDT 2016

mcrosier created this revision.
mcrosier added reviewers: mssimpso, mkuper, eeckstein.
mcrosier added a subscriber: llvm-commits.
Herald added a subscriber: mzolotukhin.

Trivial refactoring.  I was working through a few of the existing lit test cases with debug enabled and I found it to be misleading to print this message and then immediate return because the types/opcode don't match.




Index: lib/Transforms/Vectorize/SLPVectorizer.cpp
--- lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -3855,8 +3855,6 @@
   if (VL.size() < 2)
     return false;
-  DEBUG(dbgs() << "SLP: Vectorizing a list of length = " << VL.size() << ".\n");
   // Check that all of the parts are scalar instructions of the same type.
   Instruction *I0 = dyn_cast<Instruction>(VL[0]);
   if (!I0)
@@ -3878,6 +3876,8 @@
       return false;
+  DEBUG(dbgs() << "SLP: Vectorizing a list of length = " << VL.size() << ".\n");
   bool Changed = false;
   // Keep track of values that were deleted by vectorizing in the loop below.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24090.69876.patch
Type: text/x-patch
Size: 740 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160831/92b7ad33/attachment.bin>

More information about the llvm-commits mailing list