[PATCH] D23609: [ELF] - Linkerscript: support VERSION command.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 08:44:07 PDT 2016

ruiu added a comment.

What I was trying to say is to remove `IsCommand` parameter and do not rely on return value to determine what we are parsing. We should know what we are doing without that value. If you need to read X and Y, define `readX` and `readY`, instead of `readZ(bool IsX)` or something like that.


More information about the llvm-commits mailing list