[PATCH] D23609: [ELF] - Linkerscript: support VERSION command.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 09:51:35 PDT 2016

grimar added a comment.

In https://reviews.llvm.org/D23609#530418, @ruiu wrote:

> What I was trying to say is to remove `IsCommand` parameter and do not rely on return value to determine what we are parsing. We should know what we are doing without that value. If you need to read X and Y, define `readX` and `readY`, instead of `readZ(bool IsX)` or something like that.

Ok, I see. I updated the diff. Updated code looks close to what we had for parsing script file, but it has at least 2 differences atm, so I am not sure it is possible to extract common part (and if we want it here).


More information about the llvm-commits mailing list