[PATCH] D19825: Power9 - Add exploitation of vector load and store that do not require swaps

[Kit Barton via llvm-commits]

kbarton added inline comments.

================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2196
@@ -2187,3 +2195,3 @@
 
   // Patterns for which instructions from ISA 3.0 are a better match
   let Predicates = [IsLittleEndian, HasP9Vector] in {
----------------
Yes, I don't think you can remove them altogether, but predicate them so they only appear on preISA3.
Ideally you would want an inequality, but I'm not sure if that is possible. If you use !Subtarget.isISA3_0, then you need to make sure to include isISA3_0 in all future subtargets as well. 
As you said, that should eliminate the need for the AddedComplexity, which would be good. 


Repository:
  rL LLVM

https://reviews.llvm.org/D19825