[PATCH] D23609: [ELF] - Linkerscript: support VERSION command.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 07:14:45 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:706-709
@@ -703,1 +705,6 @@
   while (!atEOF() && !Error) {
+    // If this script is inside VERSION command of linkerscript,
+    // we should just exit here and let linker script parser continu
+    if (IsCommand && peek() == "}")
+      return;
+
----------------
Don't check this error inside this function. Instead, check this error outside of this function. `IsCommand` should be removed.


https://reviews.llvm.org/D23609





More information about the llvm-commits mailing list