[PATCH] D24073: [AArch64] Support stackmap/patchpoint in getInstSizeInBytes

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 06:49:35 PDT 2016

rengolin added inline comments.

Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:64
@@ -61,1 +63,3 @@
+  //        before the assembly printer.
+  unsigned NumBytes = 0;
   const MCInstrDesc &Desc = MI.getDesc();
Nit: maybe make the switch set NumBytes and return it in the end?

The unreachable down there is silly, but probably silences a compiler warning. This way, we could get rid of that, too.


More information about the llvm-commits mailing list