[lld] r280225 - [LTO/InputFiles] Merge two ifs into one. NFCI.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 05:27:48 PDT 2016


Author: davide
Date: Wed Aug 31 07:27:47 2016
New Revision: 280225

URL: http://llvm.org/viewvc/llvm-project?rev=280225&view=rev
Log:
[LTO/InputFiles] Merge two ifs into one. NFCI.

Modified:
    lld/trunk/ELF/InputFiles.cpp

Modified: lld/trunk/ELF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=280225&r1=280224&r2=280225&view=diff
==============================================================================
--- lld/trunk/ELF/InputFiles.cpp (original)
+++ lld/trunk/ELF/InputFiles.cpp Wed Aug 31 07:27:47 2016
@@ -638,17 +638,15 @@ Symbol *BitcodeFile::createSymbol(const
   uint32_t Binding = (Flags & BasicSymbolRef::SF_Weak) ? STB_WEAK : STB_GLOBAL;
 
   uint8_t Type = STT_NOTYPE;
+  uint8_t Visibility;
   bool CanOmitFromDynSym = false;
+  bool HasUnnamedAddr = false;
+
   // FIXME: Expose a thread-local flag for module asm symbols.
   if (GV) {
     if (GV->isThreadLocal())
       Type = STT_TLS;
     CanOmitFromDynSym = canBeOmittedFromSymbolTable(GV);
-  }
-
-  uint8_t Visibility;
-  bool HasUnnamedAddr = false;
-  if (GV) {
     Visibility = getGvVisibility(GV);
     HasUnnamedAddr =
         GV->getUnnamedAddr() == llvm::GlobalValue::UnnamedAddr::Global;




More information about the llvm-commits mailing list