[PATCH] D24070: Setting fp trapping mode and denormal type

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 03:28:19 PDT 2016

jmolloy added inline comments.

Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:460
@@ +459,3 @@
+      // that we want to map onto build attributes.
+      TM.resetTargetOptions(*M.begin());
+    }
rengolin wrote:
> What if we have conflicting attributes?
Then we are completely, totally, and utterly broken. Both currently and with this patch.

The LTO build attribute emission needs full-on rework and there are several FIXMEs to this effect around the AsmPrinter :(


More information about the llvm-commits mailing list