[lld] r280203 - Allow .eh_frame_hdr to be placed before .eh_frame

[Eugene Leviant via llvm-commits]

Author: evgeny777
Date: Wed Aug 31 02:43:50 2016
New Revision: 280203

URL: http://llvm.org/viewvc/llvm-project?rev=280203&view=rev
Log:
Allow .eh_frame_hdr to be placed before .eh_frame

Differential revision: https://reviews.llvm.org/D24041

Added:
    lld/trunk/test/ELF/linkerscript/linkerscript-eh-frame-hdr.s
Modified:
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=280203&r1=280202&r2=280203&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Wed Aug 31 02:43:50 2016
@@ -1306,8 +1306,13 @@ template <class ELFT> void Writer<ELFT>:
   }
 
   for (OutputSectionBase<ELFT> *Sec : OutputSections)
-    if (Sec != Out<ELFT>::Opd)
+    if (Sec != Out<ELFT>::Opd && Sec != Out<ELFT>::EhFrameHdr)
       Sec->writeTo(Buf + Sec->getFileOff());
+
+  // The .eh_frame_hdr depends on .eh_frame section contents, therefore
+  // it should be written after .eh_frame is written.
+  if (!Out<ELFT>::EhFrame->empty() && Out<ELFT>::EhFrameHdr)
+    Out<ELFT>::EhFrameHdr->writeTo(Buf + Out<ELFT>::EhFrameHdr->getFileOff());
 }
 
 template <class ELFT> void Writer<ELFT>::writeBuildId() {

Added: lld/trunk/test/ELF/linkerscript/linkerscript-eh-frame-hdr.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/linkerscript/linkerscript-eh-frame-hdr.s?rev=280203&view=auto
==============================================================================
--- lld/trunk/test/ELF/linkerscript/linkerscript-eh-frame-hdr.s (added)
+++ lld/trunk/test/ELF/linkerscript/linkerscript-eh-frame-hdr.s Wed Aug 31 02:43:50 2016
@@ -0,0 +1,20 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+# RUN: echo "SECTIONS { \
+# RUN:          .eh_frame_hdr : {} \
+# RUN:          .eh_frame : {} \
+# RUN:       }" > %t.script
+# RUN: ld.lld -o %t1 --eh-frame-hdr --script %t.script %t
+# RUN: llvm-objdump -s -section=".eh_frame_hdr" %t1 | FileCheck %s
+
+# CHECK:      0158 011b033b 14000000 01000000 49000000
+# CHECK-NEXT: 0168 30000000
+
+.global _start
+_start:
+ nop
+
+.section .dah,"ax", at progbits
+.cfi_startproc
+ nop
+.cfi_endproc