[PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 19:29:20 PDT 2016

reames added a comment.

This seems to have landed a couple of days ago without problem, but if anyone sees any weird effects in shared builds for Linux, this change is probably the culprit.  The last time I tried to do something like this, I had to back out my change due to linker errors I never had the time to understand on some of the build bots.

Comment at: llvm/trunk/include/llvm/Support/Registry.h:132
@@ +131,3 @@
+  namespace llvm { \
+  template<> void REGISTRY_CLASS::add_node(REGISTRY_CLASS::node *N) { \
+    if (Tail) \
Minor style comment: Extracting the body of add_node into an add_node_impl which is still static and having the macro just pound out a wrapper would be a bit cleaner.  



More information about the llvm-commits mailing list