[PATCH] D23931: [XRay] ARM 32-bit no-Thumb support in LLVM

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 19:18:38 PDT 2016

dberris added inline comments.

Comment at: lib/CodeGen/XRayInstrumentation.cpp:92
@@ +91,3 @@
+          TII->get(TargetOpcode::PATCHABLE_FUNCTION_EXIT));
+        break; //FIXME: is this correct? Can't a MachineBasicBlock have multiple return instructions?
+      }
Yes, this is definitely not correct. This is a remnant of some refactoring I've done and it stuck around. :(

Let me add a test and fix, should be trivial.


More information about the llvm-commits mailing list