[PATCH] D24053: [WebAssembly] Disable folding of GA+reg into load/store constant offsets

Derek Schuff via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 16:07:15 PDT 2016


dschuff added inline comments.

================
Comment at: test/CodeGen/WebAssembly/address-offsets.ll:39
@@ -34,4 +38,3 @@
 ; CHECK-NEXT: i32.const $push0=, 2{{$}}
-; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
-; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
-; CHECK-NEXT: return    $pop2{{$}}
+; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
+; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
----------------
mgrang wrote:
> dschuff wrote:
> > @sunfish not sure how you feel about this method of disabling tests. The other option would be just to delete them and use revision control for its purpose :)
> This seems to be a typo. Should be NEXT instead of NEX T.
It's actually kind of a hacky way of disabling tests without actually deleting them. The drawback is, yeah it kind of looks like a typo.


https://reviews.llvm.org/D24053





More information about the llvm-commits mailing list