[PATCH] D18226: Codegen: Tail-duplicate during placement.
Kyle Butt via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 30 15:03:43 PDT 2016
iteratee marked 2 inline comments as done.
Comment at: lib/CodeGen/BranchFolding.cpp:709
@@ +708,3 @@
+ if (Block1.empty())
+ // On some platforms return instructions are marked as indirect
+ // branches and not as return instructions. Work around this by
> How abut Block1.back().isIndirectBranch() && !Block1.back().isReturn() ?
I checked. There are platforms where the "return" instruction does not return true for isReturn after epilog lowering.
Mips, Hexagon, Thumb.
I think I'll re-write the comment so that it sounds less like a workaround.
More information about the llvm-commits