[PATCH] D24011: [ConstantFold] Add a flag for ppc_fp128 constant folding, since APFloat doesn't support double-double semantic

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 14:38:55 PDT 2016


timshen added a comment.

In https://reviews.llvm.org/D24011#529529, @hubert.reinterpretcast wrote:

> In https://reviews.llvm.org/D24011#529508, @timshen wrote:
>
> > If there seems to be few applications are depending on this optimization, I wonder if we can turn off the constant folding for now, and fix APFloat later if someone really cares about it?
>
>
> Just wanted to note that the front-end would still encounter the issue with APFloat, and I would be concerned if the (front-end) constant expression evaluation for ppc_fp128 is disabled entirely.


Good note. No, we don't touch the front-end currently. :)


https://reviews.llvm.org/D24011





More information about the llvm-commits mailing list