[PATCH] D24039: Fixed spill stack objects are mutable

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 13:38:56 PDT 2016

hfinkel added a comment.

In https://reviews.llvm.org/D24039#529406, @reames wrote:

> At least per documentation, spill slots should be created via CreateSpillStackObject.  I think you may be fixing the wrong bug.  Even if not silently disabling all optimization for existing callers is not acceptable.

I'm not quite sure that's right: Some ABIs have fixed-offset spill slots (e.g. PowerPC). Calling a spill slot immutable seems odd anyway, given that, by definition, you store into it. Also, they have isAliased == false regardless.



More information about the llvm-commits mailing list