[PATCH] D24037: [LTO] Fix the logic for dropping unnamed_addr

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 11:42:21 PDT 2016


rafael added inline comments.

================
Comment at: ELF/SymbolTable.cpp:222
@@ -221,2 +221,3 @@
     Sym->IsUsedInRegularObj = false;
+    Sym->HasUnnamedAddr = false;
     Sym->ExportDynamic = false;
----------------
Maybe change this to true.

================
Comment at: ELF/SymbolTable.cpp:245
@@ +244,3 @@
+  // Merge in the new unnamed_addr attribute.
+  if (WasInserted)
+    S->HasUnnamedAddr = HasUnnamedAddr;
----------------
And then you don't need this if, no?


https://reviews.llvm.org/D24037





More information about the llvm-commits mailing list