[PATCH] D24041: [ELF] Linkerscript: allow .eh_frame_hdr to go before .eh_frame

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 10:53:13 PDT 2016


>
>    for (OutputSectionBase<ELFT> *Sec : OutputSections)
> -    if (Sec != Out<ELFT>::Opd)
> +    if (Sec != Out<ELFT>::Opd && Sec != Out<ELFT>::EhFrameHdr)
>        Sec->writeTo(Buf + Sec->getFileOff());
> +
> +  if (!Out<ELFT>::EhFrame->empty() && Out<ELFT>::EhFrameHdr)
> +    Out<ELFT>::EhFrameHdr->writeTo(Buf + Out<ELFT>::EhFrameHdr->getFileOff());


The second if can be just

if (Out<ELFT>::EhFrameHdr)

no?

LGTM.

Cheers,
Rafael


More information about the llvm-commits mailing list