[PATCH] D23768: [ELF] Linkerscript: eliminate LayoutInputSection

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 08:36:14 PDT 2016

> * Assigning offsets as we assign sections to output sections

Please keep in mind that output section size and symbol values depend on
output section VA,
because you can have the following kind of expression within section

. = ALIGN(0x8);

I will wait for Rui, just in case he wants something to be fixed before
landing this patch.

2016-08-30 18:26 GMT+03:00 Rafael EspĂ­ndola <rafael.espindola at gmail.com>:

> > I think the code can be simplified further (I am experimenting with it),
> but this is a step in the right direction.
> Some things I tried:
> * Assigning offsets as we assign sections to output sections. That is
> too early as '.' needs the address, and for that we need the alignment
> of the output section.
> * Storing in InputSectionDescription which sections it found. With
> this assignOffsets can be simpler as we visit the assignments and
> sections in the right order. This is probably worth it, but handling
> the orphan sections is still a bit annoying.
> I will probably send the second patch for review once this one is in.
> Cheers,
> Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160830/632ca5e1/attachment-0001.html>

More information about the llvm-commits mailing list