[PATCH] D23768: [ELF] Linkerscript: eliminate LayoutInputSection

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 06:53:06 PDT 2016

On 30 August 2016 at 09:10, Eugene Leviant <evgeny.leviant at gmail.com> wrote:
> evgeny777 added a comment.
> Yeah. See lines 294-295 in LinkerScript.cpp. Also, please take a look at linkerscript-symbols-synthetic.s

Yes, I missed that the lambda was updating the outer Off variable.

This is definitely an improvement. I guess my only remaining question
is why do you need to set OutSec to -1?

I think it might be possible to simplify things further by assigning
offsets earlier, but that can be an independent patch.


More information about the llvm-commits mailing list