[PATCH] D23965: Add StringRef::keep_front() and StringRef::keep_back()
Zachary Turner via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 30 06:42:02 PDT 2016
Does anyone have a tie breaker? I'd like to het this in today if possible
On Mon, Aug 29, 2016 at 1:22 PM Adrian McCarthy <amccarth at google.com> wrote:
> amccarth added a comment.
> I'm torn on the naming debate. I think `take_back` is awkward, and using
> `first` and `last` instead of `front` and `back` would make the new names
> inconsistent with `drop_front` and `drop_back` (and with STL container
> naming). I also see that point that `keep` is less precise.
> Everything else LGTM.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits