[PATCH] D23603: [ELF] - Linkerscript: merge section attributes when create output section.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 05:37:18 PDT 2016

Has anyone hit a problem in the wild with us creating multiple
sections? If not I think we should just go back to creating multiple

If we do have to create a single one we should probably do what gold
does and have a 2 step merging (input-section -> chunk ->
output-section) and the factory would still be used for the first


On 17 August 2016 at 07:18, George Rimar via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> grimar created this revision.
> grimar added a reviewer: ruiu.
> grimar added subscribers: llvm-commits, grimar, davide, evgeny777.
> If there are input sections with the same name but with different attributes
> and linker script layout is used then we create single output section.
> What is wrong is that we create an output section based on the first input
> section's attributes. This may make a wrong output section attributes,
> patch fixes the issue.
> https://reviews.llvm.org/D23603
> Files:
>   ELF/LinkerScript.cpp
>   ELF/OutputSections.cpp
>   ELF/OutputSections.h
>   test/ELF/linkerscript/linkerscript-phdrs.s
>   test/ELF/linkerscript/linkerscript-repsection-va.s
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

More information about the llvm-commits mailing list