[PATCH] D23930: [AArch64] Fix encoding for lsl #12 in add/sub immediates

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 05:09:53 PDT 2016


rengolin added a comment.

In https://reviews.llvm.org/D23930#528683, @rovka wrote:

> Also, I think it would be difficult to maintain assembly that relies on this property: .space 0x1000 works, but .space 0x1000 - 4 gives an "immediate out of range" error, which just looks surprising unless you figure out to inspect the encodings.


You'd be surprised how some people use the assembler... :)

But that's for another patch.

I also agree with Peter. But would be good to get some Darwin perspective. @t.p.northover?


https://reviews.llvm.org/D23930





More information about the llvm-commits mailing list