[PATCH] D23768: [ELF] Linkerscript: eliminate LayoutInputSection

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 03:35:04 PDT 2016

evgeny777 added inline comments.

Comment at: ELF/InputSection.h:51-52
@@ -33,3 +50,4 @@
 // This corresponds to a section of an input file.
-template <class ELFT> class InputSectionBase {
+template <class ELFT> class InputSectionBase : public InputSectionData {
ruiu wrote:
> Now the "Base" class has a base class? I seems to me that it's too object-oriented-ish, but let's see how it works.
Unfortunately SymbolAssignment is not (and shouldn't be) template class. 
Also I think that moving data which doesn't depend on template parameter ELFT to the base non-template class should slightly reduce image size.



More information about the llvm-commits mailing list