[PATCH] D23913: [ELF] - Linkerscript: implemented ADDR command.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 15:02:16 PDT 2016

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.


Comment at: ELF/LinkerScript.cpp:1071
@@ -1047,1 +1070,3 @@
 static uint64_t getHeaderSize() {
grimar wrote:
> Amount of such bulky methods in this class is large enough already. I suggest to land https://reviews.llvm.org/D23872 or something else first.
This is somewhat agree indeed, but I don't like to introduced a new class and virtual calls to workaround too. I'm probably OK with this for now.


More information about the llvm-commits mailing list