[PATCH] D24004: [ThinLTO] Indirect call promotion fixes for promoted local functions

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 14:32:11 PDT 2016


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM as well.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:376
@@ -375,2 +375,3 @@
     legacy::PassManagerBase &MPM) {
+
   // Allow forcing function attributes as a debugging and tuning aid.
----------------
Spurious empty line?

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:440
@@ -430,1 +439,3 @@
+    // for imported functions.
+    MPM.add(createPGOIndirectCallPromotionLegacyPass());
   }
----------------
Do we want to do this in the compile phase?


https://reviews.llvm.org/D24004





More information about the llvm-commits mailing list