[PATCH] D23661: [ELF] Fix sorting in combrelocs mode and add DT_REL(A)COUNT to .dynamic

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 14:21:37 PDT 2016


On 29 August 2016 at 17:11, Rui Ueyama <ruiu at google.com> wrote:
> Yes, it says that the field is optional, but it doesn't say that it should
> be interpreted as zero if absent. So it seems to me that writing zero is the
> right thing if it is actually zero.

This is fine by me. The reason being that this field exists to support
an optimization. If the field is missing or is zero, the result has to
be the same: there is nothing to optimize.

Eugene, can you say how your dynamic linker uses this? Last time we
tried it had no impact on load times with glibc.

Cheers,
Rafael


More information about the llvm-commits mailing list