[llvm] r279417 - [LTO] Handles commons in monolithic LTO

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 14:07:22 PDT 2016

> +    // Common resolution: collect the maximum size/alignment.
> +    // FIXME: right now we ignore the prevailing information, it is not clear
> +    // what is the "right" behavior here.

I think the correct behaviour is to expect the linker to keep as
prevailing the GV with the largest size and for the linker to update
the alignment.

The rationale is that is that keeping the largest avoids the need for
RAUW since the alignment can be set in place.

An API like this would require the gold plugin to keep the old hack,
but IMHO that is fair since it is working around a deficiency in the
gold plugin api.


More information about the llvm-commits mailing list