[llvm] r279417 - [LTO] Handles commons in monolithic LTO

[Rafael Espíndola via llvm-commits]

> +    // Common resolution: collect the maximum size/alignment.
> +    // FIXME: right now we ignore the prevailing information, it is not clear
> +    // what is the "right" behavior here.

I think the correct behaviour is to expect the linker to keep as
prevailing the GV with the largest size and for the linker to update
the alignment.

The rationale is that is that keeping the largest avoids the need for
RAUW since the alignment can be set in place.

An API like this would require the gold plugin to keep the old hack,
but IMHO that is fair since it is working around a deficiency in the
gold plugin api.

Cheers,
Rafael