[PATCH] D24001: [CMake] Use top-level CMake file when building compiler-rt builtins

[Chris Bieneman via llvm-commits]

I think I have a fix for this. The problem actually is that the LLVM_LIBRARY_OUTPUT_* variables aren’t actually set in LLVMConfig.cmake. In the runtimes build we explicitly set them based on values from that file.

For the builtins we need to forcibly set those values correctly on the configuration. Once we do that this should work as expected.

I’m testing it now and will commit if it works.

-Chris

> On Aug 29, 2016, at 1:10 PM, Chris Bieneman via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> The builtins build should already be using llvm-config to construct the required paths (see compiler-rt/lib/builtins/CMakeLists.txt:17). The fact that this isn’t working is a bug.
> 
> -Chris
> 
> 
>> On Aug 29, 2016, at 1:05 PM, Petr Hosek <phosek at google.com> wrote:
>> 
>> phosek added a comment.
>> 
>> Alternatively, we could modify compiler-rt's CMake build to use `llvm-config` to figure out the correct install path and Clang version when being built as standalone (although that's somewhat orthogonal to this issue).
>> 
>> 
>> Repository:
>> rL LLVM
>> 
>> https://reviews.llvm.org/D24001
>> 
>> 
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits