[PATCH] D24000: [experimental] Add support for live-in semantics of values in deopt bundles

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 11:19:55 PDT 2016

reames created this revision.
reames added reviewers: sanjoy, igor-laevsky, atrick, ributzka.
reames added a subscriber: llvm-commits.
Herald added subscribers: mcrosier, sanjoy.

This is a first step towards supporting deopt value lowering and reporting entirely with the register allocator.  I hope to build on this in the near future to support live-on-return semantics, but I have a use case which allows me to test and investigate code quality with just the live-in semantics so I've chosen to start there.  For those curious, my use cases is our implementation of the "__llvm_deoptimize" function we bind to @llvm.deoptimize.  I'm choosing not to hard code that fact in the patch and instead make it configurable via function attributes.

The basic approach here is modelled on what is done for the "Live In" values on stackmaps and patchpoints.  (A secondary goal here is to remove one of the last barriers to merging the pseudo instructions.)  We start by adding the operands directly to the STATEPOINT SDNode.  Once we've lowered to MI, we extend the remat logic used by the register allocator to fold virtual register uses into StackMap::Indirect entries as needed.  This does rely on the fact that the register allocator rematerializes.  If it didn't along some code path, we could end up with more vregs than physical registers and fail to allocate.

Today, we *only* fold in the register allocator.  This can create some weird effects when combined with arguments passed on the stack because we don't fold them appropriately.  I have an idea how to fix that, but it needs this patch in place to work on that effectively.  (There's some weird interaction with the scheduler as well, more investigation needed.)

My near term plan is to land this patch off-by-default, experiment in my local tree to identify any correctness issues and then start fixing codegen problems one by one as I find them.  Once I have the live-in lowering fully working (both correctness and code quality), I'm hoping to move on to the live-on-return semantics.  Note: I don't have any *known* miscompiles with this patch enabled, but I'm pretty sure I'll find at least a couple.  Thus, the "experimental" tag and the fact it's off by default.  

p.s. I'm not particularly attached to any of the attribute names or  any of the other how aspects of how we decide to enable.  If anyone has a better idea here, please make suggestions.  



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24000.69589.patch
Type: text/x-patch
Size: 16245 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160829/518ba85c/attachment.bin>

More information about the llvm-commits mailing list