[PATCH] D23474: COFF: add beginnings of debug directory creation

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: COFF/Writer.cpp:58
@@ +57,3 @@
+
+    for (const auto &Record : Records) {
+      D->Characteristics = 0;
----------------
auto -> std::unique_ptr<Chunk>

================
Comment at: COFF/Writer.cpp:74
@@ +73,3 @@
+private:
+  const std::vector<std::unique_ptr<Chunk>> &Records;
+};
----------------
Why don't you use ArrayRef?


Repository:
  rL LLVM

https://reviews.llvm.org/D23474