[llvm] r269909 - Don't pass a Reloc::Model to MC.

Steven Wu via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 09:06:30 PDT 2016

> On Aug 29, 2016, at 5:57 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> On 29 August 2016 at 08:26, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>>>> -  if (RelocM == Reloc::Static) {
>>>> +  if (!PositionIndependent) {
>>> ^ This comparison is not an exact rewrite. For DynamicNoPIC relocation model, it uses "__DATA,__mod_func_init" before but now it goes to "__TEXT,__constructor". Maybe a new field for whether the binary is dynamic is needed.
>> Are there any position dependent users left? Can we switch to always
>> using "__DATA,__mod_func_init"?
I am not aware of any but I suspect there can still be. We are moving away from full static and even dynamic-no-pic but there is always legacy users and low level firmware users find them useful.

> Never mind, it was easy to fix: r279967
Thanks a lot! 


> Cheers,
> Rafael

More information about the llvm-commits mailing list