[PATCH] D23940: Delete dead code

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 06:29:56 PDT 2016


>> Yes, that is the kind of thing that could be handled uniformly by
>> having the IR explicitly say what can be assumed to be dso local, but
>> we don't have that feature yet.
>
> Right, my idea was to do something like adding “visibility hidden” on *declarations* when we have this passed-in by the linker, and update shouldAssumeDSOLocal to look for this.

Yes, having something like it is probably a good thing. I was working
on it before:

https://reviews.llvm.org/D20217
https://reviews.llvm.org/D21839
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160627/368016.html

The point of this review is that the code right now is dead as we
don't have where to plug it in llvm.

Cheers,
Rafael


More information about the llvm-commits mailing list