[PATCH] D23962: [Polly] Allow mapping scalar MemoryAccesses to array elements.

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 04:39:11 PDT 2016

Meinersbur added a comment.

Thank you for the review. Do you have any comment on the `get(Original|Latest)XXX` naming scheme? It is what I originally used, but it feels clunky. Ideally I'd distinguish between whether the access is explicit (caused by a MemInst)/implicit (cross-Stmt registers+PHIs) and what it accesses (array/scalar alloca).

Comment at: test/Isl/CodeGen/MemAccess/map_scalar_access___%outer.for---%return.jscop.transformed:1
@@ +1,2 @@
+   "arrays" : [
grosser wrote:
> Could you possibly also commit the original .jscop file. I tried to do this consistently to make it easy to see the changes by just calling 'diff' between the original and the transformed jscop file.
OK. Didn't know the purpose of those files.


More information about the llvm-commits mailing list