[PATCH] D22840: Split the store of an int value merged from a pair of smaller values into multiple stores.

[Wei Mi via llvm-commits]

wmi added a comment.

It is weird. However, I just realized in your example, alloca was replaced with a func param. It can make the test more shorter, so I updated the test again.


================
Comment at: lib/Target/X86/X86ISelLowering.h:778-780
@@ +777,5 @@
+        if (Opd.getValueType().isFloatingPoint())
+          return true;
+      }
+      // If the pair only contains int values, we will save two bitwise
+      // instructions and increase one store instruction. The benefit is
----------------
chandlerc wrote:
> I agree the cost will be low, I just think it makes sense to mention the different aspects (for example, saving an entry in the store buffer).
Got it. Added the comment. 


Repository:
  rL LLVM

https://reviews.llvm.org/D22840