[PATCH] D20046: [AVR] Add assembly parser

Dylan McKay via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 23:05:04 PDT 2016


dylanmckay added inline comments.

================
Comment at: lib/Target/AVR/AsmParser/AVRAsmParser.cpp:11
@@ +10,3 @@
+#include "llvm/ADT/APInt.h"
+#include "llvm/ADT/StringSwitch.h"
+#include "llvm/MC/MCContext.h"
----------------
Good catch. It'll be a leftover from when I started copying from the MIPS backend. Fixed.

================
Comment at: lib/Target/AVR/AsmParser/AVRAsmParser.cpp:46
@@ +45,3 @@
+  bool MatchAndEmitInstruction(SMLoc IDLoc, unsigned &Opcode,
+                               OperandVector &Operands, MCStreamer &Out,
+                               uint64_t &ErrorInfo,
----------------
You're right - updated that now.


Repository:
  rL LLVM

https://reviews.llvm.org/D20046





More information about the llvm-commits mailing list