[PATCH] D23799: [ESan][MIPS] Adds support for MIPS64

[Derek Bruening via llvm-commits]

bruening added inline comments.

================
Comment at: lib/esan/esan.cpp:150
@@ +149,3 @@
+  // This is based on the assumption that the intial stack is always allocated
+  // in the topmost segment of the virtual address space and the assumption
+  // holds true on all the platforms currently supported.
----------------
nit: for x86-64 the vsyscall region is a higher address than the stack

================
Comment at: lib/esan/esan_shadow.h:136
@@ -135,3 @@
-// We'll want to use templatized functions over the ShadowMapping once
-// we support more platforms.
-#error Platform not supported
----------------
This was overlooked?


Repository:
  rL LLVM

https://reviews.llvm.org/D23799