[PATCH] D23939: IfConversion: Fix branch predication bug.

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 14:39:59 PDT 2016


davidxl added inline comments.

================
Comment at: lib/CodeGen/IfConversion.cpp:1778
@@ -1782,4 +1777,3 @@
 
-  if (RemoveTrueBranch)
-    BBI1->NonPredSize -= TII->RemoveBranch(*BBI1->BB);
+  BBI1->NonPredSize -= TII->RemoveBranch(*BBI1->BB);
   // Remove duplicated instructions.
----------------
Is trueBranch always analyzable?

================
Comment at: lib/CodeGen/IfConversion.cpp:1807
@@ -1807,1 +1806,3 @@
+    DI2++;
+  }
   while (NumDups2 != 0) {
----------------
Why  skipping debug value here? Does that affect the NumDups2 adjustment below?


Repository:
  rL LLVM

https://reviews.llvm.org/D23939





More information about the llvm-commits mailing list