[PATCH] D23672: Start reifying error descriptions

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 10:56:34 PDT 2016


kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. 
Please ping the next change that you want me to review


================
Comment at: lib/asan/asan_errors.h:50
@@ +49,3 @@
+  ErrorKind kind;
+  // (filcab): We're using a tagged union because it allows us to have a
+  // trivially copiable type and use the same structures as the public
----------------
don't include the user name here (that's not a TODO)


https://reviews.llvm.org/D23672





More information about the llvm-commits mailing list