[PATCH] D23672: Start reifying error descriptions

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 09:58:17 PDT 2016


kcc added inline comments.

================
Comment at: lib/asan/asan_errors.h:50
@@ +49,3 @@
+  ErrorKind kind;
+  // (filcab): I'd rather avoid inheritance + virtual functions since that makes
+  // the type non-trivially copiable. I would like to have the same structures
----------------
Sorry, I did not mean to literally copy the discussion into the comments.
The comment should not be in a form of discussion, but in a form of statement. 

// We do X because Y and Z


https://reviews.llvm.org/D23672





More information about the llvm-commits mailing list