[PATCH] D23564: [RISCV 7/10] Add RISCVInstPrinter and basic MC assembler tests

David Chisnall via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 06:47:59 PDT 2016


theraven accepted this revision.
theraven added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Target/RISCV/InstPrinter/RISCVInstPrinter.cpp:24
@@ +23,3 @@
+#define DEBUG_TYPE "asm-printer"
+
+// Include the auto-generated portion of the assembly writer.
----------------
Not much danger of ambiguity - I doubt many people are debugging LLVM with test cases that emit assembly for two different architectures in the same test run...


https://reviews.llvm.org/D23564





More information about the llvm-commits mailing list