[PATCH] D23751: [ELF] Linkerscript: define symbols outside SECTIONS

Fri Aug 26 00:34:19 PDT 2016

grimar added a comment.

In https://reviews.llvm.org/D23751#525490, @phosek wrote:

> Do you have any opinion on what to do about this? I'd say that since we already support having multiple `SECTIONS` commands and it works reasonable (as in the same as in BFD ld), there's no reason to break that functionality in which case the current patch is probably a better albeit a slightly uglier solution? I still feel feel that renaming `HasContents` to `HasSections` would improve the readability.

Question is addressed to Rui, but
FWIW I think multiple 'SECTIONS' is a bit confusing and uncommon. I think I never saw that in real projects though reviewed many scripts in the wild. Anybody really needs it ?
So if breaking support can help to improve the code I would probably do that.

I agree that 'HasSections' is sounds more readable because currently HasContent actually used only to check if we have SECTIONS command or not.

https://reviews.llvm.org/D23751